Remove undefined behavior from QMessageLogContext#1399
Merged
ahayzen-kdab merged 1 commit intoKDAB:mainfrom Mar 27, 2026
Merged
Remove undefined behavior from QMessageLogContext#1399ahayzen-kdab merged 1 commit intoKDAB:mainfrom
ahayzen-kdab merged 1 commit intoKDAB:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13457 13457
=========================================
Hits 13457 13457 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
771fd43 to
14aade7
Compare
ahayzen-kdab
approved these changes
Mar 27, 2026
Collaborator
ahayzen-kdab
left a comment
There was a problem hiding this comment.
LGTM :-) Good catch on the CStr::from_ptr, and yes those unsafe are not needed probably a misunderstanding how CXX requires unsafe when pointers are used in arguments but it doesn't matter for return types :-)
And yes adding namespaces on the C++ side would be good and that const assert is already on the C++ side and not really checking anything else, so feel free to tidy up in another PR :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the safety documentation for
CStr::from_ptr, the pointer must be non-null. Currently, the functions forQMessageLogContextdo not check for null pointers. This PR adds those checks, removing the undefined behavior.Note: cxx-qt-lib's qtlogging code is noticeably messy. In addition to the above undefined behavior, it has extraneous
unsafespecifiers and a pointless const assertion that was probably supposed to occur on the C++ side, and its functions are in the global namespace rather thanrust::cxxqtlib1. It also solely exposes undocumented internal functionality and doesn't respect category disabling. I made #1398 to serve as an alternative for it.