Goとライブラリの更新、gopherjsからwasmに変更 #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makiuchi-d
commented
Dec 24, 2024
|
|
||
| func (s *grpcServer) Dial() (*grpc.ClientConn, error) { | ||
| return grpc.Dial(fmt.Sprintf("%s:%d", s.Host, s.Port), | ||
| return grpc.NewClient(fmt.Sprintf("%s:%d", s.Host, s.Port), |
There was a problem hiding this comment.
Dial is Deprecated.
https://pkg.go.dev/google.golang.org/grpc#Dial
makiuchi-d
commented
Dec 24, 2024
| publicProps: binary.Unmarshaled; | ||
| privateProps: binary.Unmarshaled; | ||
| created: Timestamp.AsObject | undefined; | ||
| created: string | undefined; |
There was a problem hiding this comment.
Timestamp型が内部でunixtimeをBigInt型で持っているために
そのままではJSONエンコードできないので文字列として返すようにしました。
この値はfrontendでは使っていないです。
superkerokero
approved these changes
Dec 25, 2024
|
toplevel awaitを使っているのにtsconfigのtargetがes2020だったのでes2022に直しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goのprotobufを更新したらgopherjs（go v1.19）ではビルドできなくなってしまいました。
gopherjsの更新が遅いことと、Go本体がwasmをサポートし始めたことから、gopherjsの部分をwasmに置き換えてみました。
wasmを利用するにはcommonjsではなくesmoduleにする必要があり、
dashboardのbackendを結構書き換えることになりました……
serverの変更内容
dashboardのbackendの変更内容
cjsとesmの違いをきちんとは理解できていないので、なにか変なことしていたら指摘おねがいします