Skip to content

[Feat] Notification 추가 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-parkk merged 32 commits into from
Dec 16, 2025
Merged

[Feat] Notification 추가 #362

Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
ef2e84a
feat: gitignore 추가
david-parkk Nov 30, 2025
492f0f6
feat: FCM gradle 추가
david-parkk Dec 1, 2025
dda4fe5
feat: 테스트 FCM API 추가
david-parkk Dec 1, 2025
82e3b37
test: 테스트 추가
david-parkk Dec 1, 2025
08e6a1c
feat: 토큰 추가 API
david-parkk Dec 1, 2025
86e966e
feat: baseEntity 상속 추가
david-parkk Dec 1, 2025
e49f571
test: 테스트 추가
david-parkk Dec 1, 2025
b852f22
Merge branch 'develop' of https://github.com/david-parkk/backend into…
david-parkk Dec 7, 2025
72042b7
fix: gitignore 수정
david-parkk Dec 8, 2025
99b8add
feat: 메서드 분리
david-parkk Dec 8, 2025
c4f7ebb
feat: FCM Message 구현체 작성
david-parkk Dec 8, 2025
bf382f0
test: 테스트 변경
david-parkk Dec 8, 2025
df5dea4
feat: ci submodule 추가
david-parkk Dec 8, 2025
1904df2
fix: Fcm Config 수정
david-parkk Dec 9, 2025
5f5d835
fix: application.yml test 수정
david-parkk Dec 9, 2025
2707594
test: 테스트 추가
david-parkk Dec 9, 2025
4ecfa7c
resolve: take develop submodule pointer for config
kmw10693 Dec 9, 2025
a94d0ca
resolve: take develop submodule pointer for config
kmw10693 Dec 9, 2025
b018424
fix: 리뷰 반영
david-parkk Dec 10, 2025
2bc9956
Merge branch 'feat/#345' of https://github.com/KU-rum/backend into fe…
david-parkk Dec 10, 2025
fa5560b
fix: 리뷰 반영
david-parkk Dec 11, 2025
fc8b1ec
fix: 에러 추적 stacktrace 추가
david-parkk Dec 13, 2025
d6dc9e7
Merge branch 'develop' of https://github.com/KU-rum/backend into fix/…
david-parkk Dec 13, 2025
3bc3364
fix: FCM gradle
david-parkk Dec 13, 2025
df5218c
Merge branch 'develop' of https://github.com/KU-rum/backend into fix/…
david-parkk Dec 13, 2025
ae7b373
Merge branch 'develop' of https://github.com/KU-rum/backend into fix/…
david-parkk Dec 13, 2025
dee79b9
fix: FCM Function
david-parkk Dec 13, 2025
a483d78
Merge branch 'fix/#358' of https://github.com/KU-rum/backend into fix…
david-parkk Dec 13, 2025
363c2db
Merge branch 'develop' into fix/#358
david-parkk Dec 13, 2025
8848940
feat: Notifiction 추가
david-parkk Dec 16, 2025
e122148
Merge branch 'fix/#358' of https://github.com/KU-rum/backend into fix…
david-parkk Dec 16, 2025
7960d2c
Merge branch 'develop' of https://github.com/KU-rum/backend into fix/…
david-parkk Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/main/java/ku_rum/backend/domain/alarm/application/FcmService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import com.google.firebase.messaging.FirebaseMessagingException;
import com.google.firebase.messaging.Message;
import com.google.firebase.messaging.MulticastMessage;
import com.google.firebase.messaging.Notification;
import java.util.List;
import java.util.Optional;
import ku_rum.backend.domain.alarm.domain.repository.UserFcmTokenRepository;
Expand Down Expand Up @@ -43,8 +44,15 @@ public void sendToUsers(FcmDirectDto request) {
.map(UserFcmToken::getToken)
.toList();
validateUserToken(users, tokens);

MulticastMessage message = MulticastMessage.builder()
.addAllTokens(tokens)
.setNotification(
Notification.builder()
.setTitle(request.title())
.setBody(request.body())
.build()
)
.putData("title", request.title())
.putData("body", request.body())
.build();
Comment on lines +47 to 58
Copy link

@coderabbitai coderabbitai bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

fd FcmService.java -type f

Repository: KU-rum/backend

Length of output: 228

🏁 Script executed:

find . -name "FcmService.java" -type f | head -5

Repository: KU-rum/backend

Length of output: 129

🏁 Script executed:

rg "issue.*358|error.*1404" -i --max-count 20

Repository: KU-rum/backend

Length of output: 213

🏁 Script executed:

cat -n src/main/java/ku_rum/backend/domain/alarm/application/FcmService.java

Repository: KU-rum/backend

Length of output: 6172

🏁 Script executed:

rg "FCM_SEND_ERROR|1404" -B 5 -A 5 src/main/java/ku_rum/backend/global/support/status/BaseExceptionResponseStatus.java

Repository: KU-rum/backend

Length of output: 734

🏁 Script executed:

git log --oneline -20 -- src/main/java/ku_rum/backend/domain/alarm/application/FcmService.java

Repository: KU-rum/backend

Length of output: 139

FCM 알림 페이로드 추가로 시스템 알림 자동 표시 개선

MulticastMessage에 notification 페이로드가 올바르게 추가되었습니다. Notification.builder().setTitle().setBody().build() 패턴은 Firebase Admin SDK의 공식 권장 방식이며, 이를 통해 시스템 알림이 자동으로 표시됩니다. Data 페이로드와 notification 페이로드를 동시에 사용하는 것은 유효한 패턴입니다.

sendToTopic() 메서드(75-80행)도 동일한 패턴으로 일관성 있게 구현되어 있습니다.

🤖 Prompt for AI Agents 
In src/main/java/ku_rum/backend/domain/alarm/application/FcmService.java around
lines 47 to 58, ensure the MulticastMessage includes a Notification payload so
system notifications are shown automatically; replace the current
MulticastMessage construction with one that uses
Notification.builder().setTitle(request.title()).setBody(request.body()).build(),
adds all tokens via addAllTokens(tokens), and also includes the same data keys
(putData("title", request.title()) and putData("body", request.body())) so it
matches the sendToTopic implementation and provides both notification and data
payloads.

Expand All @@ -64,6 +72,12 @@ public void sendToTopic(FcmTopicDto request) {

Message message = Message.builder()
.setTopic(request.topic())
.setNotification(
Notification.builder()
.setTitle(request.title())
.setBody(request.body())
.build()
)
.putData("title", request.title())
.putData("body", request.body())
.build();
Expand Down
Loading