Crerate job to run linters #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Kabanosk
requested changes
Jul 23, 2024
.github/workflows/test.yml
Outdated
Comment on lines
66
to
94
|
|
||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set up Python 3.8 | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: 3.8 | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install poetry==1.8.1 | ||
| poetry install --no-root | ||
|
|
||
| - name: Run isort | ||
| run: | | ||
| poetry run isort --check-only . | ||
|
|
||
| - name: Run black | ||
| run: | | ||
| poetry run black --check . | ||
|
|
||
| - name: Run pylint | ||
| run: | | ||
| poetry run pylint **/*.py |
There was a problem hiding this comment.
Not sure if we want linting in workflow named test.yml. Maybe we can create new workflow for linting? E.g. lint.yml
There was a problem hiding this comment.
Sounds good, changed it
Co-authored-by: Wojciech Fiołka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #11