-
-
Notifications
You must be signed in to change notification settings - Fork 97
Added Pre-Commit hook support #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| - id: selene | ||
| name: selene (cargo) | ||
| description: An opinionated Lua code linter | ||
| entry: selene | ||
| language: rust | ||
| types: | ||
| - lua | ||
|
|
||
| - id: selene-system | ||
| name: selene (system) | ||
| description: An opinionated Lua code linter | ||
| entry: selene | ||
| language: system | ||
| types: | ||
| - lua | ||
|
|
||
| - id: selene-docker | ||
| name: selene (docker) | ||
| description: An opinionated Lua code linter | ||
| entry: selene | ||
| language: docker | ||
| types: | ||
| - lua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Git Hook Support | ||
|
|
||
| Selene has [githooks](https://git-scm.com/docs/githooks) support thanks to | ||
| [pre-commit](https://pre-commit.com) which means you will need to add a | ||
| configuration file - `.pre-commit-config.yaml` to your repository. Thereafter | ||
| you'll need to install the hooks and `selene` will be run against all recently | ||
| changed files before you commit the changes. | ||
|
|
||
| This section of the document details the ways you could setup `pre-commit` for | ||
| linting your Lua code before each commits. | ||
|
|
||
| In the `.pre-commit-config.yaml` file add the following configurations and then | ||
| run `pre-commit install --install-hooks` to setup the pre-commit hooks. | ||
|
|
||
| ```yaml | ||
| repos: | ||
| - repo: https://github.com/Kampfkarren/selene | ||
| rev: '' # Add the latest version of Selene here | ||
| hooks: | ||
| - selene # this will use Cargo to compile the binary before usage | ||
| - selene-system # this will use the installed binary on the system | ||
| - selene-docker # this will build a Docker image before usage | ||
| ``` | ||
|
|
||
| To ensure `pre-commit` is the latest tagged version of `selene`, run the `pre-commit autoupdate` command. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.