Fix vscode extension not respecting exclude#578
Open
chriscerie wants to merge 11 commits intoKampfkarren:mainfrom
Open
Fix vscode extension not respecting exclude#578chriscerie wants to merge 11 commits intoKampfkarren:mainfrom
chriscerie wants to merge 11 commits intoKampfkarren:mainfrom
Conversation
Kampfkarren
reviewed
Apr 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling from extension to ignore exclude paths. Ideally this logic would be handled by the cli. But the extension forwards the contents of each file to the cli to lint. It doesn't lint on files directly since it wouldn't work with unsaved changes. Since the cli doesn't have context on the file paths, it can't properly handle exclude paths.