Skip to content

fix: extend() method now merges lua_versions instead of replacing #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nurpax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: extend() method now merges lua_versions instead of replacing #646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions selene-lib/src/standard_library/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,9 @@ impl StandardLibrary {
}),
);

// Intentionally not a merge, didn't seem valuable
// Merge Lua versions instead of replacing them
if !other.lua_versions.is_empty() {
self.lua_versions = other.lua_versions;
self.lua_versions.extend(other.lua_versions);
}

self.globals = globals;
Expand Down