Conversation
aitken85
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All those fancy things we dreamed about!
This is subquery nested in the FRON statement like
SELECT * FROM (...) AS subQuery.Some of the key magic here is that the subQuery isn't built or validated until the parent query is built. Meaning you're free to modify that object after attaching it to the parent.
This is a subquery using the
WITHstatement, which is somewhat like a temporary/inline VIEW.Union also exists now, but that's pretty boring.
Having said all that. This PR description should go straight into some docs.
The test cases also need some real executed queries. Not just generated SQL.