Fix: MySQL JSON columns always need to be DB synced#18
Merged
Conversation
At least in MariaDB 10.6.24, SHOW COLUMNS and information_schema.COLUMNS both show a JSON column as 'longtext', which means the DB sync check thinks the column needs to be synced. Instead, use information_schema.CHECK_CONSTRAINTS to check for the json_valid(`some_column`) CHECK_CLAUSE, and set the column to be a JSON type if that exists, so it matches the JSON type specified in db_struct.xml
gwillz
approved these changes
Feb 19, 2026
Collaborator
gwillz
left a comment
gwillz
left a comment
There was a problem hiding this comment.
Very cool.
Check constraints were for a long time valid but largely ignored in mysql. I hope one day we can extend db_struct to sync more of these as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least in MariaDB 10.6.24,
SHOW COLUMNSandinformation_schema.COLUMNSboth show a JSON column as 'longtext', which means the DB sync check thinks the column needs to be synced.Instead, use
information_schema.CHECK_CONSTRAINTSto check for thejson_valid(`some_column`)CHECK_CLAUSE, and set the column to be a JSON type if that exists, so it matches the JSON type specified in db_struct.xml