chore: 에러 및 정규 표현식 상수화 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fluteen
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
특이 사항 (리뷰 시 참고할 내용)
혹시 프론트랑 협의된 내용이 따로 있지 않다면 response body 로 성공 메세지를 꼭 넘기지 않아도 괜찮을 것 같습니다!
(200 ok 상태코드로 이미 의도가 충분히 전달되었을 것 같다고 생각했어요)
그래서 성공 메세지에 대한 부분은 따로 상수화하지 않았습니다.
인증쪽에서 실패 메세지 상수화 안한 부분은 나중에 리팩토링 될 것 같아서 그냥 두었습니당
유효성 검사 실패 에러메세지에서 검사 실패 필드는 유효성 검사 에러 메세지가 그대로 사용자에게 보여지다보니 필드명까지 포함되어 보이면 어색하다는 말이 나와서 프론트와 협의 후 빼기로 했습니다! (로그인 관련 수정사항 #52 )
관련 이슈
close #20