(Desktop) Set UA via request handler instead of context: Fixes CookieManager#396
Closed
threethan wants to merge 3 commits into
Closed
(Desktop) Set UA via request handler instead of context: Fixes CookieManager#396threethan wants to merge 3 commits into
threethan wants to merge 3 commits into
Conversation
Contributor
Author
|
Closed in favor of #398 which makes the same change on a dedicated branch of my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the modified request context from desktop webviews.
The modified request context was previously used only to apply
WebSettings.customUserAgentString, but had the unintended side-effect of delegating all cookies to the modifiedCefRequestContext's cookie manager.WebViewState.getCookieManager()uses the global cookie manager, it was unable to access cookies within modified request context--
This PR instead applies the user agent by adding a
CefRequestHandler, which does not separate cookies.This approach still applies the user agent without any apparent downsides.
WebViewState.getCookieManager()works as expected.Resolves #395, #152