[numeric-refactor-feedback-cleanup] Numeric Input Refector Feedback #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -78 B (-0.01%) Total Size: 872 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f35dd10) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2268If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2268 |
…d clean up text-input
…ements for Numeric Input after Refactor changes.
|
|
||
| const getUniqueId = () => { | ||
| return `input-with-examples-${id}`; | ||
| }; |
There was a problem hiding this comment.
Does this need to be a function, now that it's simpler? Could we just have the following up around line 63:
const id = useId();
const ariaId = `aria-for-${id}`;
| @@ -113,7 +113,7 @@ class TextInput extends React.Component<Props> { | |||
| id={this.id} | |||
| value={formattedValue} | |||
| type="text" | |||
| aria-label={labelText || undefined} | |||
| aria-label={labelText} | |||
There was a problem hiding this comment.
I think the undefined was there so that there is no aria-label attribute when labelText is blank. Otherwise, we end up with aria-label="".
…we don't want the empty string to get set. Also some test data cleanup
mark-fitzgerald
approved these changes
Feb 25, 2025
… then update tests and snapshots to match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a little PR that addresses some additional feedback points from the Numeric Input Refactor.
This includes:
getTooltipContenttorenderTooltipContentNumericExampleStringsafter they were moved into the util file.ariaLabelsetting toundefined.Test plan: