Allow null values when parsing the domain of a locked function #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arsing the domain of a locked function
… Allow null values when parsing the domain of a locked function on an Interactive Graph widget. A null value for the upper or lower bound means infinity/unbounded.
benchristel
commented
Feb 25, 2025
| @@ -259,7 +259,8 @@ const parseLockedFunctionType: Parser<LockedFunctionType> = object({ | |||
| strokeStyle: parseLockedLineStyle, | |||
| equation: string, | |||
| directionalAxis: enumeration("x", "y"), | |||
| domain: optional(pairOfNumbers), | |||
| // TODO(benchristel): default domain to [null, null]? | |||
| domain: optional(pair(nullable(number), nullable(number))), | |||
There was a problem hiding this comment.
@nishasy would it be useful to default the domain to [null, null] if it's not present? Then the React components wouldn't need to handle the case where domain is undefined.
There was a problem hiding this comment.
I think @mark-fitzgerald recently updated this type, so he might have a better answer for you.
There was a problem hiding this comment.
@benchristel - That sounds like a good plan. Thank you!
|
Size Change: +26 B (0%) Total Size: 872 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (d0f1297) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2269If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a Perseus JSON parser error observed in production. A null value for
the upper or lower bound means infinity/unbounded, and should be allowed.
Issue: none
Test plan:
yarn test