Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-deprecated khan-exercise.css #875

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented Dec 15, 2023

Summary:

Today's the day - rm khan-exercise.css.

The khan-exercise.css stylesheet is a very old set of styles for Perseus. Many of the styles apply to elements that live in webapp and not in Perseus so they don't even belong here. Some are unscoped and so also are just bad practices. Lastly, webapp applies a CSS Reset at the start of it's styles so I suspect most of the unscoped rules are clobbered anyways.

The remaining rules will either exist in webapp/mobile already or be for elements that no longer exist.

This file just confuses things so I'm removing it today!

Issue: --none--

Test plan:

Compare current PROD with what is available in the ZND for this PR.

Editor:

  • code
    • Open an article that has CS content, such as "Public key encryption"
    • Open the editor for the article
    • Scroll down to "Section 2"
    • Hover over the tooltip below "Settings:"
    • CONFIRM: The text "Program.settings()" should look the same in both environments
  • Preview area (also called "problemarea")
    • Navigate any exercise and open its editor
    • Verify that content has been added/setup
    • CONFIRM: The preview area looks the same in both environments

Widgets & Stuff:

  • Graphie

@jeremywiebe jeremywiebe self-assigned this Dec 15, 2023
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Size Change: -6 B (0%)

Total Size: 872 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 276 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39.5 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 11.1 kB
packages/math-input/dist/es/index.js 78.2 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 29.8 kB
packages/perseus-linter/dist/es/index.js 22.8 kB
packages/perseus-score/dist/es/index.js 20.6 kB
packages/perseus/dist/es/index.js 367 kB
packages/perseus/dist/es/strings.js 6.74 kB
packages/pure-markdown/dist/es/index.js 4.14 kB
packages/simple-markdown/dist/es/index.js 13.1 kB

compressed-size-action

@jeremywiebe jeremywiebe marked this pull request as ready for review December 15, 2023 21:56
@khan-actions-bot khan-actions-bot requested a review from a team December 15, 2023 21:56
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/lovely-seahorses-hide.md, packages/perseus/src/styles/perseus-renderer.less

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.64%. Comparing base (720e3bf) to head (0c59381).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   70.00%   70.64%   +0.63%     
==========================================
  Files         514      517       +3     
  Lines      106133   106166      +33     
  Branches     7629    11489    +3860     
==========================================
+ Hits        74296    74996     +700     
+ Misses      31720    31170     -550     
+ Partials      117        0     -117     

Impacted file tree graph

see 124 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720e3bf...0c59381. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 15, 2023

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (5ff208c) and published it to npm. You
can install it using the tag PR875.

Example:

pnpm add @khanacademy/perseus@PR875

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR875

@handeyeco
Copy link
Contributor

This is great 🎉 Makes me a little nervous with the upcoming mobile app release though.

  • Should we wait to land this until after the release?
  • Do we need a full QE Perseus pass to check for issues?

@nedredmond nedredmond removed their request for review July 1, 2024 13:02
@jeremywiebe jeremywiebe force-pushed the lc-1482.content-editor-code branch 2 times, most recently from 48fa442 to a2ec0f9 Compare July 28, 2024 05:16
@jeremywiebe jeremywiebe force-pushed the lc-1482.content-editor-code branch from a2ec0f9 to 0c59381 Compare August 13, 2024 21:49
position: relative;
float: left;
padding-bottom: 38px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be used in legacy code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants