-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove long-deprecated khan-exercise.css
#875
base: main
Are you sure you want to change the base?
Conversation
Size Change: -6 B (0%) Total Size: 872 kB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 70.00% 70.64% +0.63%
==========================================
Files 514 517 +3
Lines 106133 106166 +33
Branches 7629 11489 +3860
==========================================
+ Hits 74296 74996 +700
+ Misses 31720 31170 -550
+ Partials 117 0 -117 see 124 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (5ff208c) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR875 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR875 |
This is great 🎉 Makes me a little nervous with the upcoming mobile app release though.
|
48fa442
to
a2ec0f9
Compare
a2ec0f9
to
0c59381
Compare
…om khan-exercise.css)
…-editor.less (no longer needed for IE).
…e it is no longer used.
position: relative; | ||
float: left; | ||
padding-bottom: 38px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be used in legacy code.
…sed by legacy code in Webapp.
Summary:
Today's the day -
rm khan-exercise.css
.The
khan-exercise.css
stylesheet is a very old set of styles for Perseus. Many of the styles apply to elements that live in webapp and not in Perseus so they don't even belong here. Some are unscoped and so also are just bad practices. Lastly, webapp applies a CSS Reset at the start of it's styles so I suspect most of the unscoped rules are clobbered anyways.The remaining rules will either exist in webapp/mobile already or be for elements that no longer exist.
This file just confuses things so I'm removing it today!
Issue: --none--
Test plan:
Compare current PROD with what is available in the ZND for this PR.
Editor:
code
Widgets & Stuff: