[SPIR-V] Add SPIRVGlobalInstrRegistry, don't emit OpEntryPoint/OpName in MF#257
Draft
michalpaszkowski wants to merge 5 commits intofeature/spirv-backend-llvm15_0_7_4from
Draft
Conversation
IRTranslator lowers switches to [G_SUB] + G_ICMP + G_BRCOND + G_BR sequences. Since values and destination MBBs are included in the spv_switch intrinsics, the sequences are not needed for ISel. Before this commit, the information decoded by these sequences were added to spv_switch intrinsics in SPIRVPreLegalizer and the sequences were kept until SPIRVModuleAnalysis where they were marked skipped for emission. After this commit, the [G_SUB] + G_ICMP + G_BRCOND + G_BR sequences and MBBs containing only these MIs are erased in SPIRVPreLegalizer.
michalpaszkowski
force-pushed
the
refactor_SPIRVModuleAnalysis_OpEntryPoints
branch
3 times, most recently
from
1ed9add to
00a3c26
Compare
michalpaszkowski
force-pushed
the
refactor_SPIRVModuleAnalysis_OpEntryPoints
branch
from
00a3c26 to
ed5372c
Compare
michalpaszkowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress in an effort to declutter SPIRVModuleAnalysis and avoid emitting global (module-level) instructions in MF.