clarify that format must be a string literal in OpenCL_C.txt #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the old text allowed a constant variable containing format, not just a string literal. That way, we can define these formats at the top and reuse them for multiple |
bashbaug
reviewed
Mar 4, 2025
| The format is in the constant address space and must be resolvable at | ||
| compile time, i.e. cannot be dynamically created by the executing program | ||
| itself. | ||
| The format must be a string literal. |
There was a problem hiding this comment.
I agree with @SunSerega that this is a bit too strong, at least based on the current Clang behavior, which does not require the format string to be a string literal: https://godbolt.org/z/b33jKTe7K
Is there a C or C++ term we could use instead?
There was a problem hiding this comment.
I see that Clang allows this, but it isn't happy either:
warning: format string is not a string literal (potentially insecure)
Doesn't this warning hint that format should be restricted to string literals?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent behind "resolvable at compile time" is that
formatcannot be a kernel argument (see #1325 (comment))