-
Notifications
You must be signed in to change notification settings - Fork 251
Fix MergeBlock error: a merge block for another header #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ec57cf7 to
5a7e488
Compare
|
Unit test failures: |
Working on this |
|
Any ETA on fixing the CI? |
|
@pvelesko thanks for the ping UPD: below test failure is expected
debug info test failures is fixed, need to update the HEAD of the PR |
|
rebased @MrSidims |
|
@MrSidims rebased on main now that Loop Merge is in. |
|
@MrSidims please merge if ok. Thank you. |
|
@pvelesko thanks for the fix! |
Code was assigning the same merge block to multiple headers. Added a fails as follows before the fix:
#3277 should be merged first as this test will trigger that error before hitting merge block error.