VulkanVideoParser: preserve DPB slots for key frames with partial refresh flags #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resh For AV1 key frames with show_frame=0 and refresh_frame_flags != 0xFF, preserve DPB slots that are not being refreshed. This allows subsequent inter frames to correctly reference existing decoded pictures that were not overwritten by the hidden key frame. Previously, all DPB slots could be invalidated on key frames, breaking references for inter frames following a key frame with partial refresh flags and show_frame=0.
crmurillo
force-pushed
the
issue_137_dpbslot
branch
from
9180cf1 to
0c5819e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For AV1 key frames with
show_frame=0andrefresh_frame_flags != 0xFF, preserve DPB slots that are not being refreshed. This allows subsequent inter frames to correctly reference existing decoded pictures that were not overwritten by the hidden key frame.Previously, all DPB slots could be invalidated on key frames, breaking references for inter frames following a key frame with partial refresh flags and
show_frame=0.Fixes #137. See issue for a detailed analysis.