Reword coalesced exercise README #421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to resolve the issue highlighted in KhronosGroup#326 where the "Coalesced Global Memory" exercise README was asking a user to manually calculate a linear id that would be used to index memory. However, the exercise code itself uses 2d buffers/accessors which are indexed with a `sycl::id<2>`. So the current exercise request doesn't make sense, or could only be achieved with modifications beyond what is reasonably expected for a beginner. Instead, I've updated the README to state the usage of the 2d buffer/accessors and ask the user to experiment with flipping the dimension indexes, as this is the only difference between this exercise solution, and the solution from the previous lesson ```sh $ diff Code_Exercises/Coalesced_Global_Memory/solution.cpp Code_Exercises/Image_Convolution/reference.cpp 59a60 > 77a79 > globalId = sycl::id{globalId[1], globalId[0]}; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve the issue highlighted in #326 where the "Coalesced Global Memory" exercise README was asking a user to manually calculate a linear id that would be used to index memory.
However, the exercise code itself uses 2d buffers/accessors which are indexed with a
sycl::id<2>rather than asize_t. So the current exercise request doesn't make sense, or could only be achieved with modifications beyond what is reasonably expected for a beginner.Instead, I've updated the README to state the usage of the 2d buffer/accessors and ask the user to experiment with flipping the dimension indexes, as this is the only difference between this exercise solution, and the solution from the previous lesson