Conversation
WalkthroughAdds three new JSON manifests under testnet_oro/chainlist for the Kiitestnet Oro network:
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
testnet_oro/chainlist/chain.json (1)
116-119: Normalize the explorer account URL.There’s an extra slash in
https://explorer.kiichain.io//account/${accountAddress}. Most servers tolerate it, but trimming to a single slash avoids surprises.- "account_page": "https://explorer.kiichain.io//account/${accountAddress}" + "account_page": "https://explorer.kiichain.io/account/${accountAddress}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
testnet_oro/chainlist/images/kii_oro.pngis excluded by!**/*.png
📒 Files selected for processing (3)
testnet_oro/chainlist/assetlist.json(1 hunks)testnet_oro/chainlist/chain.json(1 hunks)testnet_oro/chainlist/versions.json(1 hunks)
jhelison
left a comment
There was a problem hiding this comment.
We will be fine with the testnet_oro on the path (worried with the _)? A few assets also has references to https://raw.githubusercontent.com/cosmos/chain-registry/master/testnets/kiitestnet on which has a different pathing
Co-authored-by: Jhelison Uchoa <68653689+jhelison@users.noreply.github.com>
Co-authored-by: Jhelison Uchoa <68653689+jhelison@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
testnet_oro/chainlist/chain.json (1)
118-118: Fix double slash in explorer account_page URL.Current link will render as //account/...; use a single slash.
- "account_page": "https://explorer.kiichain.io//account/${accountAddress}" + "account_page": "https://explorer.kiichain.io/account/${accountAddress}"
🧹 Nitpick comments (2)
testnet_oro/chainlist/chain.json (2)
67-67: Consider adding persistent_peers for resiliency.You already advertise two seeds. Adding them as persistent peers improves node connectivity and bootstrapping.
- "persistent_peers": [] + "persistent_peers": [ + { + "id": "5b6aa55124c0fd28e47d7da091a69973964a9fe1", + "address": "uno.sentry.testnet.v3.kiivalidator.com:26656", + "provider": "Kiichain" + }, + { + "id": "5e6b283c8879e8d1b0866bda20949f9886aff967", + "address": "dos.sentry.testnet.v3.kiivalidator.com:26656", + "provider": "Kiichain" + } + ]
51-52: Pin genesis_url to a commit SHA for immutability
Branch refs can change; replace themainref with a specific commit SHA to lock the file:- "genesis_url": "https://raw.githubusercontent.com/KiiChain/testnets/refs/heads/main/testnet_oro/genesis.json" + "genesis_url": "https://raw.githubusercontent.com/KiiChain/testnets/<commit-sha>/testnet_oro/genesis.json"HEAD check confirms the current URL is reachable (HTTP 200).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
testnet_oro/chainlist/chain.json(1 hunks)
🔇 Additional comments (2)
testnet_oro/chainlist/chain.json (2)
3-3: chain_name consistently set to "kiitestnetoro" across chain.json, versions.json, and assetlist.json.
70-110: Endpoints validated — RPC endpoints returned HTTP/2 200, LCD endpoints returned 501 to HEAD (host reachable), JSON-RPC endpoints returned 405 to HEAD (host reachable), gRPC hostnames resolve correctly.
Description
Adds json files needed for cosmos chainlist
Type of change