-
Notifications
You must be signed in to change notification settings - Fork 959
Fix openrouter custom base url Issue [#2181] #2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
…obra91/kilocode into fix-openrouter-custom-base-url
#2385 it's not the same problem |
provider === "openrouter" | ||
? apiConfiguration?.apiKey | ||
: provider === "kilocode" | ||
? apiConfiguration?.kilocodeToken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change made? I don't think it is correct, because the Kilo Code provider doesn't have this endpoint (yet at least).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes want to reuse max code but i guess it's not good because kilo code provider don't need custom ! sorry
getModels({ provider: "openrouter" }), | ||
getModels({ | ||
provider: "openrouter", | ||
baseUrl: this.options.openRouterBaseUrl, // kilocode_change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the api key also be specified here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for openrouter who don't need apikey to fetch model list => https://openrouter.ai/api/v1/models work on browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but the same is true for getModelEndpoints isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes ! https://openrouter.ai/api/v1/models/deepseek/deepseek-r1/endpoints answer without apikey
…thub.com//issues/2181)
Context
Implementation
Screenshots
How to Test
Get in Touch