Skip to content

Conversation

cobra91
Copy link
Contributor

@cobra91 cobra91 commented Aug 28, 2025

…thub.com//issues/2181)

Context

Implementation

Screenshots

before after

How to Test

Get in Touch

Copy link

changeset-bot bot commented Aug 28, 2025

⚠️ No Changeset found

Latest commit: cd85365

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chrarnoldus chrarnoldus self-requested a review August 29, 2025 09:04
@chrarnoldus chrarnoldus self-assigned this Aug 29, 2025
@cobra91 cobra91 changed the title Fix openrouter custome base url Merge pull request [#2181] https://gi… Draft: Fix openrouter custome base url Merge pull request [#2181] https://gi… Aug 31, 2025
@cobra91 cobra91 marked this pull request as draft August 31, 2025 16:28
@chrarnoldus chrarnoldus removed their request for review September 1, 2025 16:01
@chrarnoldus chrarnoldus removed their assignment Sep 1, 2025
@cobra91 cobra91 marked this pull request as ready for review September 1, 2025 19:50
@cobra91 cobra91 changed the title Draft: Fix openrouter custome base url Merge pull request [#2181] https://gi… Fix openrouter custom base url Merge pull request [#2181] https://gi… Sep 1, 2025
@cobra91 cobra91 changed the title Fix openrouter custom base url Merge pull request [#2181] https://gi… Fix openrouter custom base url Issue [#2181] Sep 1, 2025
@cobra91
Copy link
Contributor Author

cobra91 commented Sep 15, 2025

#2385 it's not the same problem

provider === "openrouter"
? apiConfiguration?.apiKey
: provider === "kilocode"
? apiConfiguration?.kilocodeToken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made? I don't think it is correct, because the Kilo Code provider doesn't have this endpoint (yet at least).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes want to reuse max code but i guess it's not good because kilo code provider don't need custom ! sorry

getModels({ provider: "openrouter" }),
getModels({
provider: "openrouter",
baseUrl: this.options.openRouterBaseUrl, // kilocode_change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the api key also be specified here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for openrouter who don't need apikey to fetch model list => https://openrouter.ai/api/v1/models work on browser

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but the same is true for getModelEndpoints isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants