Skip to content

Conversation

@n7studios
Copy link
Contributor

@n7studios n7studios commented Dec 8, 2025

Summary

Implements Kit/convertkit-wordpress#964 and Kit/convertkit-wordpress#966 from the main Kit Plugin:

  • move token hook logic to convertkit-mm-functions.php,
  • checks the result of any refresh() call, forcibly removing credentials from the Plugin's settings if the failure is a 401
  • on initialization of a resource class, such as ConvertKit_MM_Resource_Tags, removes the ConvertKit_Resource_V4 init() call and loads cached resources.

All calls made to refresh() from the Plugin are made by the user:

  • They are on the Settings > Kit for MemberMouse screen (either going through OAuth or loading the already authenticated screen to change some settings),

Testing

  • testInvalidCredentials: Check authorization failed notice displays
  • testValidCredentials: Check no authorization failed notice displays

Checklist

@n7studios n7studios self-assigned this Dec 8, 2025
@n7studios n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team December 8, 2025 04:13
@n7studios n7studios marked this pull request as ready for review December 8, 2025 04:14
Remove WPForms Reference in Docblocks
Tests: Add Resource Integration Tests
@n7studios n7studios merged commit bcab727 into main Dec 10, 2025
32 checks passed
@n7studios n7studios deleted the delete-credentials-401 branch December 22, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants