add face and edge uuids to responses that make more geometry: #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
=======================================
Coverage ? 24.85%
=======================================
Files ? 36
Lines ? 2193
Branches ? 0
=======================================
Hits ? 545
Misses ? 1648
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thank you! |
jessfraz
reviewed
May 2, 2025
| /// The UUIDs of the entities that were created. | ||
| pub entity_ids: Vec<Uuid>, | ||
| /// The Face, edge, and entity ids of the patterned entities. | ||
| pub entity_face_edge_ids: Vec<FaceEdgeInfo>, |
There was a problem hiding this comment.
@adamchalmers do you know how we can make these bw compatible so we dont break in flux releases or should we just slow roll it out w empty vecs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.