In-app toasts for electron-updater notifications #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pierremtb
changed the title
pierremtb
changed the title
…-back-after-electron-migration
franknoirot
approved these changes
Sep 24, 2024
franknoirot
deleted the
pierremtb/issue3872-Add-custom-updater-model-back-after-electron-migration
branch
This was referenced Sep 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the default system notification and update on exit behaviour with the tauri way we had set up. This is leveraging electron dialogs for now, next step to close #3872 is to hook up the react modals.After more discussion with the team, forced auto updates seem to be the preferred route for now. This PR replaces the default system notification with an in-app toast. More things may be hooked to it later, for instance in-app changelog after updates.
First functional draft with @franknoirot's mockup (need to make it pretty now)
