chore: implemented a O(n) unique and added unit tests #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
reviewed
Nov 8, 2024
| */ | ||
| makeUniqueDiagnostics(duplicatedDiagnostics: Diagnostic[]): Diagnostic[] { | ||
| const uniqueDiagnostics: Diagnostic[] = [] | ||
| const seenDiagnostic: { [key: string]: boolean } = {} |
There was a problem hiding this comment.
I didn't use set because the objects are different and the content is the same. So I cannot do a .has check because it does not look at the keys, it looks at the object.
var a = new Set()
var b = {myVal:4}
var c = {myVal:4}
a.add(b)
a.has(c) --> false
There was a problem hiding this comment.
You could use the string that you made as the value in the set. JS objects are not sets. They have different performance characteristics. At our scale, probably doesn't matter, but it seemed natural.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jon, Lee, and myself came across this block of code when debugging a codemirror issue. I wanted to make this code quicker and more straight forward. I also added unit tests.