Skip to content

KCL: Migrate hole to kwargs #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 26, 2025
Merged

KCL: Migrate hole to kwargs #6382

merged 28 commits into from
Apr 26, 2025

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Apr 17, 2025

Previously:

|> hole(circle(radius = 2, center = p), %)

Now:

|> subtract2d(tool = circle(radius = 2, center = p))

@adamchalmers adamchalmers requested a review from jtran April 17, 2025 19:12
Copy link

qa-wolf bot commented Apr 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2025 8:31pm

Copy link

codspeed-hq bot commented Apr 17, 2025

CodSpeed Instrumentation Performance Report

Merging #6382 will not alter performance

Comparing achalmers/hole-kw (4097be0) with main (8de648f)

Summary

✅ 54 untouched benchmarks

@jtran
Copy link
Collaborator

jtran commented Apr 18, 2025

I think we decided to rename to subtract2d, right?

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (5a18f55) to head (4097be0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/kcl-lib/src/docs/mod.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6382   +/-   ##
=======================================
  Coverage   85.17%   85.18%           
=======================================
  Files         109      109           
  Lines       47104    47079   -25     
=======================================
- Hits        40123    40106   -17     
+ Misses       6981     6973    -8     
Flag Coverage Δ
rust 85.18% <97.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamchalmers adamchalmers merged commit 6e115c1 into main Apr 26, 2025
63 checks passed
@adamchalmers adamchalmers deleted the achalmers/hole-kw branch April 26, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants