Build boost b2b in release mode #631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
|
As I mentioned in email, there was an explicit reason for b2b's build to be Debug. I think there is comment about it but not descriptive enough to figure out why. Given the failure in the Linux build is Boost related, I have to imagine that it's being caused by this change. Fletch builds fine, but building kwiver got broken. Also since b2b is an internal Boost utility, I don't think we want or need to make this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't actually know enough about this change (or why it was necessary in the first place) so maybe this branch should be abandoned if there's a reason, but using the set release type from cmake caused no issues on my end so maybe the reason for the forced debug is gone/deprecated?