Fix CLI argument parsing collision #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server CLI arguments can collide with user and/or libraries argument parser.
Especially, the
ipykernelpackage CLI has a--farguments that collides with the server's--follow-symlinksand--fs-endpoints.See pyvista/pyvista#8040 and pyvista/pyvista#8044
This PR patches the issue by disallowing abbreviations.
This can be considered as a incomplete fix, since users can still have their custom CLI parser implementing one of server's argument (ie.
--follow-symlinksby mistake) and unexpectedly pass arguments to server CLI parser.Maybe we could mitigate that by including in the
tramedocumentation that when using a custom argument parser, it is recommended to pass arguments via the--trame-argsargument or with theTRAME_ARGSenv variable.