Mark all Options parameters as optional #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the types enforce you to either A) provide no options or B) provide a value for every option. In reality they all have default values and can be left "undefined" so they should be optional in the types too.
|
I was going to open an issue about this but then I figured it's such an easy fix I'll just do the PR. Basically the types as they are now can break TypeScript compilation for users of this library when they update, which is what happened to us. We are using only the |
|
@Klathmon -- any update on this? |
|
Any update on this? I'm currently using patch-package to patch this fix in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the types enforce you to either A) provide no options or B) provide a value for every option. In reality they all have default values and can be left "undefined" so they should be optional in the types too.