Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node): use node 14 #458

Merged
merged 5 commits into from
Dec 17, 2021
Merged

chore(node): use node 14 #458

merged 5 commits into from
Dec 17, 2021

Conversation

adamdehaven
Copy link
Member

@adamdehaven adamdehaven commented Dec 17, 2021 •
edited
Loading

Summary

Use node 14.x instead of 12.x

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test packages/
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@adamdehaven
chore(node): use node 14
8c74444 
Use node 14 instead of node 12.
@adamdehaven adamdehaven self-assigned this Dec 17, 2021
@chrisvdp
Copy link
Contributor

Looks like you also need to update the .nvmrc file. I wonder if we should switch to an approach like actions/setup-node#32 (comment)

@adamdehaven
fix(nvmrc): update nvmrc
43c9150 
Update version in nvmrc.
@zekth
Copy link
Member

zekth commented Dec 17, 2021

Looks like you also need to update the .nvmrc file. I wonder if we should switch to an approach like actions/setup-node#32 (comment)

That's the way to do it. +1 on this

@netlify
Copy link

netlify bot commented Dec 17, 2021 •
edited
Loading

✔️ Deploy Preview for kongponents ready!

🔨 Explore the source changes: ab8568e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kongponents/deploys/61bd01023dba0d00081c0cef

😎 Browse the preview: https://deploy-preview-458--kongponents.netlify.app

@adamdehaven
chore(actions): reference nvmrc in actions
0674dbc 
Utilize nvmrc node version value.
@adamdehaven
chore(actions): fix node variable
d3b9e2d 
Fix node variable in actions.
@adamdehaven
chore(action): fix
ab8568e 
Fix the action.
chrisvdp
chrisvdp approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@chrisvdp chrisvdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on the gh action

@adamdehaven adamdehaven merged commit cd80946 into master Dec 17, 2021
@adamdehaven adamdehaven deleted the chore/upgrade-node-version branch December 17, 2021 21:59
@adamdehaven
Copy link
Member Author

Could have done it without you @chrisvdp; just wouldn't have been as exciting 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvdp chrisvdp chrisvdp approved these changes

Assignees

@adamdehaven adamdehaven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdehaven @chrisvdp @zekth