chore(ci) coveralls bump #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
chore/ci-fix
branch
from
5fb9f3f
to
df5e664
Compare
thibaultcha
changed the title
thibaultcha
force-pushed
the
chore/ci-fix
branch
2 times, most recently
from
2c0a19e
to
95225b2
Compare
The test is already unstable because it relies on I/O, so let's reduce the potential for it failing during CI, which has been happening a lot recently.
hishamhm
reviewed
Jun 23, 2023
| @@ -152,7 +152,7 @@ jobs: | |||
| lcov --extract lcov.info "*/ngx_wasm_module/src/*" --output-file lcov.info | |||
| - name: Coveralls Upload | |||
| if: ${{ !env.ACT && matrix.cc == 'gcc-9' }} | |||
| uses: coverallsapp/github-action@master | |||
| uses: coverallsapp/github-action@v2 | |||
There was a problem hiding this comment.
Looks like line 174 below needed the same fix. I just went ahead and pushed it myself, let's see if it runs green!
|
Hmmm yes but before merging this PR the intent was to see if it supports restarting jobs... Did you maybe do it before merging by chance? On mobile |
|
Yes, I restarted the failed jobs and it passed
…On Fri, Jun 23, 2023, 18:32 Thibault Charbonnier ***@***.***> wrote:
Hmmm yes but before merging this PR the intent was to see if it supports
restarting jobs... Did you maybe do it before merging by chance?
—
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB365MQ6CAPEDZHHIHTP6TXMYDQBANCNFSM6AAAAAAZPWCFO4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.