Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vfg): convert field-select + more tests [khcp-11336] #1584

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(vfg): convert field-select + more tests [khcp-11336] #1584

wants to merge 9 commits into from
+510 −130

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Aug 27, 2024 •
edited
Loading

Summary

Convert VFG FieldSelect to use Kongponents + add more VFG component test coverage.
Addresses KHCP-11336.

Adoption PR (with passing E2Es): https://github.com/Kong/konnect-ui-apps/pull/4209

Resources

@kaiarrowood kaiarrowood self-assigned this Aug 27, 2024
@kaiarrowood kaiarrowood force-pushed the feat/khcp-11336-vfg-field-select branch 2 times, most recently from 40bcd56 to dbad74c Compare September 10, 2024 14:57
@kaiarrowood kaiarrowood force-pushed the feat/khcp-11336-vfg-field-select branch 3 times, most recently from a2e5b2b to b8cbec0 Compare September 17, 2024 18:50
@kaiarrowood kaiarrowood force-pushed the feat/khcp-11336-vfg-field-select branch from 3773742 to 1d58deb Compare September 20, 2024 14:04
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/forms@pr-1584
@kong-ui-public/expressions@pr-1584
@kong-ui-public/entities-routes@pr-1584
@kong-ui-public/entities-plugins@pr-1584

@kaiarrowood kaiarrowood marked this pull request as ready for review September 20, 2024 16:40
@kaiarrowood kaiarrowood enabled auto-merge (squash) September 20, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeSwierlik LukeSwierlik Awaiting requested review from LukeSwierlik LukeSwierlik is a code owner

@QueaT-kong QueaT-kong Awaiting requested review from QueaT-kong QueaT-kong is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kaiarrowood kaiarrowood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiarrowood @kongponents-bot