Skip to content

Conversation

@hoc081098
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 08:53
@hoc081098 hoc081098 enabled auto-merge December 17, 2025 08:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the minimum Android SDK version from API 21 (Android 5.0 Lollipop) to API 23 (Android 6.0 Marshmallow). This change drops support for Android 5.0 and 5.1 devices, potentially enabling the use of newer Android APIs and features while reducing the testing matrix.

Key Changes

  • Updated minSdkVersion constant from 21 to 23 in the centralized app configuration

const val compileSdkVersion = 36
const val buildToolsVersion = "36.0.0"
const val minSdkVersion = 21
const val minSdkVersion = 23
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minSdkVersion has been updated to 23, but the project documentation in .github/copilot-instructions.md still references the old value. The documentation states "Minimum SDK: API 21 (Android 5.0)" on line 14 and "Min SDK: 21" on line 559. These documentation sections need to be updated to reflect the new minimum SDK version of 23 (Android 6.0) to maintain consistency between code and documentation.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.88%. Comparing base (f25e6ee) to head (0728ea9).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   61.88%   61.88%           
=======================================
  Files          37       37           
  Lines        1073     1073           
  Branches      104      104           
=======================================
  Hits          664      664           
  Misses        393      393           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hoc081098 hoc081098 merged commit e075bf3 into master Dec 17, 2025
14 checks passed
@hoc081098 hoc081098 deleted the hoc081098-patch-1 branch December 17, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants