Support convert shortcuts #1118
Conversation
koperagen
added
the
Compiler plugin
| public fun <T, R : URL?> Convert<T, R>.toIFrame( | ||
| @JvmName("toIframeFromUrlNullable") | ||
| @Refine | ||
| @Converter<IFRAME>(IFRAME::class, nullable = true) |
There was a problem hiding this comment.
The compiler can infer the <> part if you pass a KClass right? :)
There was a problem hiding this comment.
Surprisingly, no. If i remove it, compiler complains about wrong number of type arguments
There was a problem hiding this comment.
that's interesting... Then again, I've never used an annotation that takes a type argument before, maybe it's a limitation
There was a problem hiding this comment.
but do you use the type argument? Or could it work if you accept KClass<*>?
There was a problem hiding this comment.
Type argument is not needed. Initially i wanted to only use type argument, but compiler doesn't see it - only KClass get class expression. Get class works as expected without type argument
| import org.jetbrains.kotlinx.dataframe.io.* | ||
| import kotlinx.datetime.* | ||
|
|
||
| fun box(): String { |
koperagen
force-pushed
the
convert-shortcuts
branch
from
d64ef01 to
1d73a6d
Compare
plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/interpret.kt
Show resolved
Hide resolved
plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/impl/api/convert.kt
Show resolved
Hide resolved
|
|
||
| override fun Arguments.interpret(): PluginDataFrameSchema { | ||
| val converterAnnotation = functionCall.calleeReference.toResolvedFunctionSymbol()?.getAnnotationByClassId(Names.CONVERTER_ANNOTATION, session) | ||
| val to = converterAnnotation?.getKClassArgument(Name.identifier("klass"), session) |
There was a problem hiding this comment.
is this an only place where we could extract info from annotations?
There was a problem hiding this comment.
for now it's the first interpreter that relies on annotations - to reduce number of classes. imagine 20 interpreters for each to* function instead of these 3
| @@ -402,17 +482,51 @@ public fun DataColumn<String?>.convertToLocalTime( | |||
| return map { it?.let { converter(it.trim()) ?: error("Can't convert `$it` to LocalTime") } } | |||
| } | |||
|
|
|||
| @JvmName("toLocalTimeFromTLongNullable") | |||
| @Refine | |||
| @Converter(LocalTime::class, nullable = true) | |||
There was a problem hiding this comment.
It's kind of pattern to define type info for outputs, isn't it? a-la @ReturnType as a more common approach
I tried to minimize repetition and come up with somewhat generic solution. However the way framework works, we still must have delegated properties matching function arguments. I decided to not provide a way for interpreter to ignore any unknown arguments in this PR