Enables Compiler plugin for :samples #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
added
documentation
Jolanrensen
changed the title
Jolanrensen
force-pushed
the
samples-compiler-plugin-attempt
branch
from
b7cd583 to
6c63c6a
Compare
Jolanrensen
force-pushed
the
samples-compiler-plugin-attempt
branch
2 times, most recently
from
f8b6e73 to
d7b85e5
Compare
Jolanrensen
force-pushed
the
samples-compiler-plugin-attempt
branch
from
d7b85e5 to
0a18483
Compare
Jolanrensen
force-pushed
the
samples-compiler-plugin-attempt
branch
from
0a18483 to
a96e2ac
Compare
Jolanrensen
force-pushed
the
samples-compiler-plugin-attempt
branch
from
6b326c2 to
8778ec9
Compare
Jolanrensen
requested review from
AndreiKingsley,
Copilot,
koperagen and
zaleslaw
koperagen
reviewed
Sep 19, 2025
| implementation(files(dependentProjectJarPaths)) | ||
|
|
||
| // include api() dependencies from dependent projects, as they are not included in the jars | ||
| dependentProjects.forEach { |
There was a problem hiding this comment.
Another way would be to have a shadowed jar in root project
There was a problem hiding this comment.
yes, but I wasn't sure how the compiler plugin would react to a shadowed version of dataframe being on the classpath instead of the actual jar
There was a problem hiding this comment.
and I have mixed experience with the shadowJar plugin
koperagen
approved these changes
Sep 19, 2025
zaleslaw
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Overall it's an approval from my side: what is the main problem - after a few months it will be hard to restore context of changes in Gradle tasks, could you add more explanation (move from ticket description or refer on that) in the stuff related to the instrumentationJar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1432
instrumentedJarsconfiguration and artifact to each subproject with ajartask:samplescompilation depends on the jar task of each relevant moduleimplementation(projects.dataframe)in :samples with an explicit dependency on allinstrumentedJarsfrom all relevant modulesapi()) dependencies from relevant modules to :samples.