Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection sharing (WIP) #885

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Collection sharing (WIP) #885

wants to merge 2 commits into from

Conversation

Unrud
Copy link
Collaborator

@Unrud Unrud commented Oct 24, 2018

Allow sharing of collections between users. Different share modes can be implemented as plugins (e.g. read and write). Plugins can share modified versions of a collection (e.g. an address book as a calendar with birthdays). They can control read and write access to collection properties and can store their own variants (e.g. every user can have his own display name for a shared collection).

  • Share plugins
    • Basic support
    • Store private display name and color for every user (and other properties?)
    • Actually implement birthday plugin
  • Rights
    • Check if shared collections allow write access to items (currently enforced by assertions)
    • Add new permission to check if a user is allowed to share a collections to a target
  • Filesystem
    • Discover shared collections
    • Allow reading and writing of shared collections
    • Allow deletion of shared collections
    • Cache items that are modified by plugins
    • Interface for sharing (and unsharing) a collections
  • Webinterface
    • Mark collections that are shared by other users
    • UI for sharing a collection

@Tntdruid
Copy link

Very nice!

@Tntdruid
Copy link

Any ETA when its done?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 874

  • 134 of 310 (43.23%) changed or added relevant lines in 18 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.6%) to 77.596%

Changes Missing Coverage Covered Lines Changed/Added Lines %
radicale/main.py 1 3 33.33%
radicale/storage/multifilesystem/init.py 20 22 90.91%
radicale/storage/multifilesystem/delete.py 2 4 50.0%
radicale/share/init.py 24 27 88.89%
radicale/share/birthday.py 10 13 76.92%
radicale/share/read.py 10 13 76.92%
radicale/share/write.py 10 13 76.92%
radicale/storage/multifilesystem/get.py 6 9 66.67%
radicale/storage/multifilesystem/upload.py 7 10 70.0%
radicale/storage/multifilesystem/move.py 13 17 76.47%
Totals Coverage Status
Change from base Build 870: -3.6%
Covered Lines: 2947
Relevant Lines: 3691

💛 - Coveralls

@pbiering
Copy link
Collaborator

@Unrud : would it make sense to continue here?

Potentially this would be a way forward related to #1499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants