CI test: PR #2403 MSVC fix - #1
Draft
Kreijstal wants to merge 3 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR validates an MSVC portability fix by moving exception-index capture to a common scope and passing that stable value to interrupt hooks across targets, removing target-specific preprocessor logic from the callback call. Sequence diagram for stable exception delivery to interrupt hookssequenceDiagram
participant CPU as CPUState
participant Exec as cpu_handle_exception
participant Hook as InterruptHook
CPU->>Exec: cpu_handle_exception(cpu, ret)
Exec->>Exec: capture cpu->exception_index
Exec->>Exec: handle target-specific exception
Exec->>Hook: callback(uc, hook_exception, user_data)
Hook-->>Exec: return
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Kreijstal
force-pushed
the
fix/riscv-architectural-traps
branch
from
August 30, 2026 06:23
ed1b582 to
795fde3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary draft PR to validate the MSVC portability fix before amending upstream PR unicorn-engine#2403.
Summary by Sourcery
Fix interrupt exception handling portability for MSVC by consistently preserving the exception index passed to hooks.
Bug Fixes:
Enhancements: