Skip to content

CI test: PR #2403 MSVC fix - #1

Draft
Kreijstal wants to merge 3 commits into
fix/riscv-architectural-trapsfrom
ci/pr2403-msvc-fix
Draft

CI test: PR #2403 MSVC fix#1
Kreijstal wants to merge 3 commits into
fix/riscv-architectural-trapsfrom
ci/pr2403-msvc-fix

Conversation

@Kreijstal

@Kreijstal Kreijstal commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Temporary draft PR to validate the MSVC portability fix before amending upstream PR unicorn-engine#2403.

Summary by Sourcery

Fix interrupt exception handling portability for MSVC by consistently preserving the exception index passed to hooks.

Bug Fixes:

  • Ensure interrupt hooks receive a consistent exception index across MSVC and supported targets.

Enhancements:

  • Simplify exception handling by capturing the exception index once before target-specific interrupt processing.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR validates an MSVC portability fix by moving exception-index capture to a common scope and passing that stable value to interrupt hooks across targets, removing target-specific preprocessor logic from the callback call.

Sequence diagram for stable exception delivery to interrupt hooks

sequenceDiagram
    participant CPU as CPUState
    participant Exec as cpu_handle_exception
    participant Hook as InterruptHook

    CPU->>Exec: cpu_handle_exception(cpu, ret)
    Exec->>Exec: capture cpu->exception_index
    Exec->>Exec: handle target-specific exception
    Exec->>Hook: callback(uc, hook_exception, user_data)
    Hook-->>Exec: return
Loading

File-Level Changes

Change Details Files
Make the interrupt-hook exception value target-independent and MSVC-compatible.
  • Capture cpu->exception_index once before target-specific exception handling.
  • Remove the RISC-V-only temporary and use the shared value when invoking interrupt callbacks.
  • Simplify the callback invocation by eliminating conditional preprocessor arguments.
qemu/accel/tcg/cpu-exec.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Kreijstal
Kreijstal force-pushed the fix/riscv-architectural-traps branch from ed1b582 to 795fde3 Compare August 30, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant