Conversation
Merge all changes on main to the 0.5.0 release branch
Signed-off-by: David Martin <davmarti@redhat.com>
Signed-off-by: David Martin <davmarti@redhat.com>
Signed-off-by: craig <cbrookes@redhat.com>
Signed-off-by: craig <cbrookes@redhat.com>
| --create-namespace \ | ||
| --namespace mcp-system \ | ||
| --version 0.5.0-rc1 \ | ||
| --version 0.5.0 \ |
There was a problem hiding this comment.
note do we want have this also replaced based on the branch?
There was a problem hiding this comment.
Sounds reasonable.
We could have 2 options here for sensible default as well:
- just reference
mainand never update - the version on main default to always reference the latest released (so never an rc or
main)
For the 2nd option, we could add this to the end of the RELEASING.md file
After the final release is published, update main to reference the new stable version:
git checkout main
git pull
git checkout -b update-version-to-X.Y.Z
./scripts/set-release-version.sh X.Y.Z
# commit, push, open PR to main
|
Tested locally and seems to be working ok. I do see errors with test server images, but this doesn't stop the install script from getting to the end I deliberately removed all mcp-gateway related images before to reproduce this issue seen by @RHCFerreira Thinking how best to solve this... |
|
@david-martin if we are applying some test servers we could use an kustomize overlay to set the imagePullPolicy to IfNotPresent. The reason for Never is so it always uses the local image. I hit bugs in the test servers and if you update them locally with IfNotPresent it doesn't pick up the new image. So Never makes sense for local dev but IfNotPresent makes sense for demos etc |
@david-martin some changes here for the quick start as it was failing when running from main. Also the v0.5.0 branch had an errant space causing an issue also. We can prob merge to main and cherry-pick to v0.5?