Skip to content

Comments

Quick start v5#613

Open
maleck13 wants to merge 5 commits intomainfrom
quick-start-v5
Open

Quick start v5#613
maleck13 wants to merge 5 commits intomainfrom
quick-start-v5

Conversation

@maleck13
Copy link
Contributor

@david-martin some changes here for the quick start as it was failing when running from main. Also the v0.5.0 branch had an errant space causing an issue also. We can prob merge to main and cherry-pick to v0.5?

david-martin and others added 5 commits February 4, 2026 10:24
Merge all changes on main to the 0.5.0 release branch
Signed-off-by: David Martin <davmarti@redhat.com>
Signed-off-by: David Martin <davmarti@redhat.com>
Signed-off-by: craig <cbrookes@redhat.com>
Signed-off-by: craig <cbrookes@redhat.com>
--create-namespace \
--namespace mcp-system \
--version 0.5.0-rc1 \
--version 0.5.0 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note do we want have this also replaced based on the branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.
We could have 2 options here for sensible default as well:

  • just reference main and never update
  • the version on main default to always reference the latest released (so never an rc or main)

For the 2nd option, we could add this to the end of the RELEASING.md file

After the final release is published, update main to reference the new stable version:
  git checkout main
  git pull
  git checkout -b update-version-to-X.Y.Z
  ./scripts/set-release-version.sh X.Y.Z
  # commit, push, open PR to main

@david-martin
Copy link
Member

Tested locally and seems to be working ok.

I do see errors with test server images, but this doesn't stop the install script from getting to the end

kubectl get po -A|grep -v -i running
NAMESPACE            NAME                                         READY   STATUS              RESTARTS   AGE
mcp-test             mcp-test-server1-6d89bc676f-gj2x6            0/1     ErrImageNeverPull   0          48s
mcp-test             mcp-test-server2-56bdd5999-vwl2b             0/1     ErrImageNeverPull   0          46s

I deliberately removed all mcp-gateway related images before to reproduce this issue seen by @RHCFerreira

Thinking how best to solve this...

@maleck13
Copy link
Contributor Author

@david-martin if we are applying some test servers we could use an kustomize overlay to set the imagePullPolicy to IfNotPresent. The reason for Never is so it always uses the local image. I hit bugs in the test servers and if you update them locally with IfNotPresent it doesn't pick up the new image. So Never makes sense for local dev but IfNotPresent makes sense for demos etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants