Fix/physics engine correction #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new simulation based on Quantum Field Theory (QFT)
to model the user's concept of "Cosmic Duality" as a two-way process of
creation and annihilation.
This work was the result of a research and synthesis phase where standard
physics models were investigated as analogies for Walter Russell's
cosmogony. The user selected the QFT model over a driven two-level
system.
The implementation includes:
1. A new function `construct_qft_hamiltonian` in
`src/advanced_quantum_simulation.py` that builds the Hamiltonian
`H = ε(a†a) + g(a† + a)` using creation and annihilation operators
in a truncated Fock space.
2. A new script `src/run_qft_simulation.py` that runs the simulation
from a vacuum state and plots the expectation value of the particle
number over time, providing a clear visualization of the creation
and annihilation dynamics.
3. A new test suite `tests/test_qft_simulation.py` that verifies the
Hermiticity of the Hamiltonian and confirms its eigenvalues match
the theoretical values in the non-interacting (g=0) case.
4. Updated documentation in `README.md` describing the new model, its
physical interpretation, and instructions on how to run the
simulation.
This commit combines all the recent work to correct the repository's
foundational issues and implement new, user-specified models. It
replaces multiple flawed modules with correct, verifiable, and
well-documented code.
The changes include:
1. **Core Physics Correction:**
- The `enhanced_hamiltonian` in `src/advanced_quantum_simulation.py`
has been corrected to use the physically sound unitary dressing
transformation (`Ĉ Ĥ₀ Ĉ†`) instead of an incorrect additive form.
- The "Rhythmic Balanced Interchange" term (`Ĥ_RB(t)`) has been
corrected to be a proper, operator-valued term, resolving the
original dimensional analysis errors.
2. **Quantum Chemistry Solver Rewrite:**
- The old, critically flawed solver modules (`quantum_solver.py`,
`hybrid_solver.py`, `molecular_hamiltonian.py`) have been deleted.
- A new, correct solver has been implemented from scratch in
`src/electronic_structure_solver.py` using the industry-standard
`qiskit-nature` library. This ensures the underlying physics and
mathematics are robust and correct.
3. **New QFT "Cosmic Duality" Simulation:**
- Based on user selection, a new simulation has been added to model
the concepts of "Generation" and "Radiation".
- This is implemented with the Hamiltonian `H = ε(a†a) + g(a + a†)`
using creation and annihilation operators, which directly models
the creation and destruction of particles from a vacuum.
- A new run script (`src/run_qft_simulation.py`) and visualization
have been added to demonstrate this "two-way motion".
4. **Major Code Refactoring and Testing:**
- The codebase has been significantly refactored to separate concerns,
with distinct modules for core physics, the QHR model, visualization,
and the new solvers.
- New, rigorous test suites have been added for both the corrected
"Russell" physics and the new QFT model, verifying properties like
Hermiticity and correctness against known analytical results.
5. **Documentation and Dependency Updates:**
- The `README.md` has been extensively updated to reflect all new
models and corrections.
- `requirements.txt` has been updated to include all necessary
dependencies for the new implementations.
This commit combines all the recent work to correct the repository's
foundational issues and implement new, user-specified models. It
replaces multiple flawed modules with correct, verifiable, and
well-documented code.
The changes include:
1. **Core Physics Correction:**
- The `enhanced_hamiltonian` in `src/advanced_quantum_simulation.py`
has been corrected to use the physically sound unitary dressing
transformation (`Ĉ Ĥ₀ Ĉ†`) instead of an incorrect additive form.
- The "Rhythmic Balanced Interchange" term (`Ĥ_RB(t)`) has been
corrected to be a proper, operator-valued term, resolving the
original dimensional analysis errors.
2. **Quantum Chemistry Solver Rewrite:**
- The old, critically flawed solver modules (`quantum_solver.py`,
`hybrid_solver.py`, `molecular_hamiltonian.py`) have been deleted.
- A new, correct solver has been implemented from scratch in
`src/electronic_structure_solver.py` using the industry-standard
`qiskit-nature` library. This ensures the underlying physics and
mathematics are robust and correct.
3. **New QFT "Cosmic Duality" Simulation:**
- Based on user selection, a new simulation has been added to model
the concepts of "Generation" and "Radiation".
- This is implemented with the Hamiltonian `H = ε(a†a) + g(a + a†)`
using creation and annihilation operators, which directly models
the creation and destruction of particles from a vacuum.
- A new run script (`src/run_qft_simulation.py`) and visualization
have been added to demonstrate this "two-way motion".
4. **Major Code Refactoring and Testing:**
- The codebase has been significantly refactored to separate concerns,
with distinct modules for core physics, the QHR model, visualization,
and the new solvers.
- New, rigorous test suites have been added for both the corrected
"Russell" physics and the new QFT model, verifying properties like
Hermiticity and correctness against known analytical results.
5. **Documentation and Dependency Updates:**
- The `README.md` has been extensively updated to reflect all new
models and corrections.
- `requirements.txt` has been updated to include all necessary
dependencies for the new implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Complete rewrite of physics engine and solvers
This commit combines all the recent work to correct the repository's
foundational issues and implement new, user-specified models. It
replaces multiple flawed modules with correct, verifiable, and
well-documented code.
The changes include:
Core Physics Correction:
enhanced_hamiltonianinsrc/advanced_quantum_simulation.pyhas been corrected to use the physically sound unitary dressing
transformation (
Ĉ Ĥ₀ Ĉ†) instead of an incorrect additive form.Ĥ_RB(t)) has beencorrected to be a proper, operator-valued term, resolving the
original dimensional analysis errors.
Quantum Chemistry Solver Rewrite:
quantum_solver.py,hybrid_solver.py,molecular_hamiltonian.py) have been deleted.src/electronic_structure_solver.pyusing the industry-standardqiskit-naturelibrary. This ensures the underlying physics andmathematics are robust and correct.
New QFT "Cosmic Duality" Simulation:
the concepts of "Generation" and "Radiation".
H = ε(a†a) + g(a + a†)using creation and annihilation operators, which directly models
the creation and destruction of particles from a vacuum.
src/run_qft_simulation.py) and visualizationhave been added to demonstrate this "two-way motion".
Major Code Refactoring and Testing:
with distinct modules for core physics, the QHR model, visualization,
and the new solvers.
"Russell" physics and the new QFT model, verifying properties like
Hermiticity and correctness against known analytical results.
Documentation and Dependency Updates:
README.mdhas been extensively updated to reflect all newmodels and corrections.
requirements.txthas been updated to include all necessarydependencies for the new implementations.