Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure numbers where we expected booleans parse correctly. #1108

Open
wants to merge 3 commits into
base: main/4
Choose a base branch
from
Open

ensure numbers where we expected booleans parse correctly. #1108

wants to merge 3 commits into from

Commits on Sep 9, 2024

  1. ensure numbers where we expected booleans parse correctly. 

    Boolean.parseBoolean expects the literal "true", which doesn't match the number 1.

The fix is to parse "1" as truthy, and all other values as falsy, like Boolean.parseBoolean() does.

fixes PaperMC/Velocity#1286
    @456dev
    456dev committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    01f5b11 View commit details
    Browse the repository at this point in the history

  2. Fix Test

    @456dev
    456dev committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    943f9bd View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. remove unused import

    @kezz
    kezz committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4d0cb74 View commit details
    Browse the repository at this point in the history