Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .dockerignore #21

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Update .dockerignore #21

merged 2 commits into from
Jan 17, 2025

Conversation

ibrahimhroob
Copy link
Contributor

@ibrahimhroob ibrahimhroob commented Jan 17, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Problem

The Docker build process for the fruit_detector service was encountering issues due to an excessively large build context. Specifically, unnecessary files and directories were being included in the build context, leading to longer build times, increased resource usage, and the potential for errors like max depth exceeded.

Solution

To resolve this issue, the .dockerignore file was updated to exclude irrelevant and unnecessary files and directories from the build context. This ensures that only essential files are included, optimizing the build process and reducing the likelihood of errors.

Changes Made

  • Added entries to the .dockerignore file to exclude:
    • Version control files and folders (.git).
    • Dependency directories (node_modules).
    • Temporary and log files (logs, tmp).
    • Any specific directories that should not be part of the build context (e.g., fruit_detector_ws/src/aoc_fruit_detector).

Benefits

  • Faster and more efficient Docker builds.
  • Reduced risk of encountering recursion-related errors like max depth exceeded.
  • Cleaner build context, improving maintainability and resource usage.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes.

[optional] Are there any post deployment tasks we need to perform?

@ibrahimhroob ibrahimhroob self-assigned this Jan 17, 2025
@yilmazabdurrah yilmazabdurrah merged commit 6974241 into main Jan 17, 2025
2 checks passed
@yilmazabdurrah yilmazabdurrah deleted the ibrahimhroob-patch-2 branch January 17, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants