Unified multiarch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable VSCode and zrok installation in nvidia.dockerfile
… adding multi-platform support
…d consolidating image tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves significant changes to the Docker build workflows and the Dockerfile to support OpenGL and NVIDIA CUDA. The most important changes include renaming and updating the workflow files, modifying the Dockerfile to use a new base image, and adding support for OpenGL and VNC.
Changes to workflow files:
.github/workflows/docker-build-opengl.yaml: Removed the entire workflow file, which included building OpenGL-supported Docker images for various CUDA versions..github/workflows/docker-build.yaml: Renamed the workflow to "Build OpenGL-supported Docker Images," updated the base images, and added new steps for setting up Node.js and Docker metadata. Removed the schedule trigger and added a fail-fast strategy. [1] [2] [3]Changes to Dockerfile:
Dockerfile: Changed the base image tonvidia/cuda:11.8.0-runtime-ubuntu22.04, added installation steps for OpenGL dependencies, timezone, and ROS2, and created a non-root user. Added support for VirtualGL, TurboVNC, and noVNC, and included entrypoint scripts for starting TurboVNC.