Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial answers to questions that were asked #49

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

tomeichlersmith
Copy link
Member

@tomeichlersmith tomeichlersmith commented Feb 28, 2025

This resolves #38

@tomeichlersmith
Copy link
Member Author

@tvami I'm not sure if this is enough, it feels too short, but I'm curious about what should be explain more in your opinion.

@tvami
Copy link
Member

tvami commented Feb 28, 2025

I'd add that we have analyzers and producers (and I guess conditions), and everything is derived from that.
Maybe generally too some comment on why we have to configure things in python, together with an example, you know to say that we have a C++ code (RunHeaderAnalyzer.cxx) that inherits from an analyzer base class (EventProcessor.cxx with a class type), which then goes into a python class def class RunHeaderAna(Analyzer) :. Ohhh and then the fact that each module is under its own namespace?

Copy link
Member

@tvami tvami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@tomeichlersmith tomeichlersmith marked this pull request as ready for review March 5, 2025 16:33
@tomeichlersmith tomeichlersmith merged commit 4f0e54e into trunk Mar 5, 2025
@tomeichlersmith tomeichlersmith deleted the 38-framework-structure branch March 5, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page on Framework structure
2 participants