Skip to content

Rename CMake option CHAI_DISABLE_RM to CHAI_ENABLE_MANAGER #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adayton1 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Rename CMake option CHAI_DISABLE_RM to CHAI_ENABLE_MANAGER #250

adayton1 wants to merge 2 commits into from

Conversation

@adayton1
Copy link
Member

@adayton1 adayton1 commented Mar 4, 2024

  • Rename to avoid a confusing double negative

@adayton1 adayton1 requested review from liu15, rchen20 and robinson96 March 4, 2024 17:56
@adayton1
Copy link
Member Author

adayton1 commented Mar 4, 2024

I'm going to wait until after the release to merge this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchen20 rchen20 rchen20 approved these changes

@liu15 liu15 liu15 approved these changes

@robinson96 robinson96 Awaiting requested review from robinson96

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adayton1 @rchen20 @liu15