Skip to content

Commit

Permalink
Make commit hashes consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
tresf committed Feb 11, 2025
1 parent e29cfff commit f16ae56
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/Artifacts.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ private function mapBranchAssetsFromJson(array $json): array
return new Asset(
platform: $parsed->getPlatform(),
platformName: $parsed, // __toString()
releaseName: 'g' . substr($artifact['workflow_run']['head_sha'], 0, 9),
releaseName: '@' . substr($artifact['workflow_run']['head_sha'], 0, 7),
downloadUrl: $this->router->generate('download_artifact', ['id' => $artifact['id']]),
description: null,
gitRef: $artifact['workflow_run']['head_sha'],
Expand All @@ -103,7 +103,7 @@ private function mapPullRequestAssetsFromJson(array $json, string $pr, string $d
return new Asset(
platform: $parsed->getPlatform(),
platformName: $parsed, // __toString()
releaseName: '#' . $pr . '@' . substr($artifact['workflow_run']['head_sha'], 0, 9),
releaseName: '#' . $pr . ' @' . substr($artifact['workflow_run']['head_sha'], 0, 7),
downloadUrl: $this->router->generate('download_artifact', ['id' => $artifact['id']]),
description: $description,
gitRef: $artifact['workflow_run']['head_sha'],
Expand Down
2 changes: 1 addition & 1 deletion templates/download/pull-request.twig
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<div class="alert alert-danger">
{% trans with {'%download%': path('download')} %}Anyone can open a pull request against LMMS; we are not responsible for the builds on this page.<br>Unless you were directed here to test a pull request, please download an official build from the <a href="%download%">main download page</a> instead.{% endtrans %}
</div>
<h3>{{ 'Pull Request #%id%'|trans({'%id%': id}) }}</h3>
<h3>{% trans %}Pull Request {% endtrans %} <a href="https://github.com/lmms/lmms/pull/{{ id }}">#{{ id }}</a></h3>
{% for asset in artifacts %}
{{ download.printrelbutton(asset, 'btn-secondary') }}
{% endfor %}
Expand Down

0 comments on commit f16ae56

Please sign in to comment.