Add Qt6 Support #7339
Add Qt6 Support #7339
Conversation
|
I successfully built LMMS with Qt 6.8.0 on Linux without the When compiling, there were a number of deprecation warnings unrelated to that change that we should probably address in this PR. |
I'm wondering if we should put our efforts into fixing merge conflicts with the |
|
@tresf I'd be fine with that. Maybe Windows MSVC could be our Qt 6 build in the CI since it wouldn't be hard to update the dependency to Qt 6, and the MinGW build is still available in case any issues arise with it. We could do it in this PR after fixing the merge conflicts. |
- Fix linking issues with Qt Framework files - Fix qmake detection
Fix implicit conversion from int when using QString.arg(...)
* Adds win32EventFilter a wrapper for nativeEventFilter on Windows * win32EventFilter is currently used to intercept top-level Window events (currently, to avoid VSTs setting transparency of the parent application)
QComboBox activated() replaced with textActivated() since Qt 5.14
* enabled VST support for Qt 6 builds * Note : Embedding on QT6 will be buggy on linux as a result of using qt embedding, which unfortunately is a qt bug which hasn't been resolved.
* Added lines in between bars * Changed bar lines to follow snap size * Changed default zoom and quantization value * Added constants for line widths * Added QSS configuration for new grid line colors * Tied line widths to QSS properties * Changed default quantization to 1/4 * Removed clear() from destructor model * Removed destructor in ComboBoxModel.h * Changed member set/get functions to pass by value * Updated signal connection with newer syntax
* ensured mouse event != nullptr before deref * separation of concerns: AFP WaveView updateCursor extract check to pointerCloseToStartEndOrLoop() * marked some function parameters as const
| @@ -212,7 +212,7 @@ TimePos AutomationClip::timeMapLength() const | |||
| if (m_timeMap.isEmpty()) { return one_bar; } | |||
|
|
|||
| timeMap::const_iterator it = m_timeMap.end(); | |||
| auto last_tick = static_cast<tick_t>(POS(it - 1)); | |||
| auto last_tick = static_cast<tick_t>(POS(std::prev(it))); | |||
There was a problem hiding this comment.
Hmm... are any of these changes Qt related?
| if( it+1 == m_clip->getTimeMap().end() ) | ||
| const auto nit = std::next(it); | ||
|
|
||
| if( nit == m_clip->getTimeMap().end() ) |
There was a problem hiding this comment.
Same goes for these, are these Qt related?
Merge conflicts fixed. Some touched lines don't appear to be related to this PR I've started a conversation thread on these files, please mark as resolved if they're warranted. The history is a bit weird (as most rebases are) and I made plenty of mistakes merging, but the branch should be in pretty good shape right now. I think it's ready for a CI job to run against Qt6 as well as a few set of eyes particularly from those that have helped with the code leading up to this point. Please push patches directly to this branch. |
I chose Qt 6.5 because it's the last Qt LTS release with declared support for Visual Studio 2019. Once we upgrade to Visual Studio 2022, we could upgrade Qt as well.
Also fixes two memory leaks in MidiWinMM
Resolves #6614.