Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight files in FileBrowser #7700

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AW1534
Copy link
Contributor

@AW1534 AW1534 commented Feb 10, 2025

I am redoing #7419 in two smaller steps.

  • Instead of just saying "Open containing folder" in the context menu it now says "Show file in [File Explorer / Finder / file manager]" depending on OS. You can now also open folders by right clicking them too.
  • Added File highlighting when displaying a file from the mentioned option. Aside from Windows and Mac, this works on: nautilus, dolphin, thunar, pcmanfm, nemo, caja, io.elementary.files, spacefm, pcmanfm-qt and any other file manager that supports the --select cli option can easilly be added. note that this falls back to the old system if a compatible file manager can't be found.

I've tested this on windows, and It was working on Linux (Manjaro, GNOME, Nautilus) back when i originally wrote this, and not much has changed since then.

@AW1534
Copy link
Contributor Author

AW1534 commented Feb 10, 2025

Turns out my code was fine, its just that without LV2 support, item->isTrack() returns the wrong value. This causes the context menu to always display the options for presets (send to instrument track).

Example ![image](https://github.com/user-attachments/assets/c7d3ef45-ab2c-4717-ac0a-3b7a4a484b69)

Works fine with the CI Built binaries. I'll be removing some debug code and opening this PR up for review.

@AW1534 AW1534 marked this pull request as ready for review February 10, 2025 02:48
@AW1534 AW1534 marked this pull request as draft February 10, 2025 20:01
@AW1534 AW1534 marked this pull request as ready for review February 10, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant