Issue/705/tangential shear approximations [version:1.17.0]#706
Merged
Issue/705/tangential shear approximations [version:1.17.0]#706
Conversation
hsinfan1996
requested changes
Apr 10, 2026
hsinfan1996
reviewed
Apr 13, 2026
Collaborator
hsinfan1996
left a comment
There was a problem hiding this comment.
The test coverage is not 100%.
Collaborator
|
The missed line should be parent_class.py line 1296. |
hsinfan1996
approved these changes
Apr 14, 2026
Collaborator
|
Do we also want to compare 'type0' in demo_theory_functionality_diff_z_types.ipynb? |
Member
Author
I talked to @marina-ricci and we decided to hide |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves #705
Main changes
orderwithtypeforapproxargs.type1in tangential_shearorder1astype0in tangential_shearChecklist
Besides passing all CI checks and coverage is at 100%, make sure you also checked the following items
(check details in CONTRIBUTING).
For developers
For reviewers
For developers (part 2)
After the PR has been approved by two reviewers:
clmm/__ini__.py.environment.yml,pyproject.toml,INSTALL.md, andREADME.md. A maintainer should also be notified to change the requirements on conda-forge.clmm/theory/_ccl_supported_versions.pyandclmm/theory/ccl.pyif pyccl's version constraints have been altered.