Skip to content

Issue/705/tangential shear approximations [version:1.17.0]#706

Merged
m-aguena merged 13 commits intomainfrom
issue/705/tangential_shear_approximations
Apr 17, 2026
Merged

Issue/705/tangential shear approximations [version:1.17.0]#706
m-aguena merged 13 commits intomainfrom
issue/705/tangential_shear_approximations

Conversation

@m-aguena
Copy link
Copy Markdown
Member

@m-aguena m-aguena commented Apr 10, 2026

Description

Solves #705

Main changes

  • Change order with type for approx args.
  • Restore Applegate14 as type1 in tangential_shear
  • Rename the old order1 as type0 in tangential_shear

Checklist

Besides passing all CI checks and coverage is at 100%, make sure you also checked the following items
(check details in CONTRIBUTING).

For developers

  • Notebooks: notebooks related to this PR have been updated and all notebooks can run correctly.
  • Build the documentation: All documentation builds correctly.

For reviewers

  • Notebooks: notebooks related to this PR have been updated and all notebooks can run correctly.
  • Build the documentation: All documentation builds correctly.

For developers (part 2)

After the PR has been approved by two reviewers:

  • Update the code version in clmm/__ini__.py.
  • Keep only relevant points in the squash and merge commit message.
  • If any dependencies have been altered, update environment.yml, pyproject.toml, INSTALL.md, and README.md. A maintainer should also be notified to change the requirements on conda-forge.
  • Update clmm/theory/_ccl_supported_versions.py and clmm/theory/ccl.py if pyccl's version constraints have been altered.

@m-aguena m-aguena requested review from combet and hsinfan1996 April 10, 2026 15:25
@github-actions github-actions Bot changed the title Issue/705/tangential shear approximations Issue/705/tangential shear approximations [version:1.17.0] Apr 10, 2026
@m-aguena m-aguena linked an issue Apr 10, 2026 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 10, 2026

Coverage Status

coverage: 100.0%. remained the same — issue/705/tangential_shear_approximations into main

Comment thread clmm/theory/func_layer.py Outdated
Comment thread clmm/theory/func_layer.py Outdated
@m-aguena m-aguena requested a review from hsinfan1996 April 13, 2026 12:35
Copy link
Copy Markdown
Collaborator

@hsinfan1996 hsinfan1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test coverage is not 100%.

@hsinfan1996
Copy link
Copy Markdown
Collaborator

The missed line should be parent_class.py line 1296.

@m-aguena m-aguena requested a review from hsinfan1996 April 13, 2026 17:08
@hsinfan1996
Copy link
Copy Markdown
Collaborator

Do we also want to compare 'type0' in demo_theory_functionality_diff_z_types.ipynb?

@m-aguena
Copy link
Copy Markdown
Member Author

Do we also want to compare 'type0' in demo_theory_functionality_diff_z_types.ipynb?

I talked to @marina-ricci and we decided to hide type0 for now

@m-aguena m-aguena merged commit 270e9a5 into main Apr 17, 2026
5 checks passed
@m-aguena m-aguena deleted the issue/705/tangential_shear_approximations branch April 17, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix use of approximation in shear profile

3 participants