Skip to content

escape all CGI form input #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yymao merged 1 commit into from
Nov 6, 2025
Merged

escape all CGI form input #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions descqaweb/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import print_function, unicode_literals
import sys
import cgi
import html
from jinja2 import Environment, PackageLoader

from . import config
Expand All @@ -24,7 +25,7 @@ def run():
form = cgi.FieldStorage()

if form.getfirst('file'):
print_file(form.getfirst('file'))
print_file(html.escape(form.getfirst('file')))
return

print('Content-Type: text/html; charset=utf-8')
Expand All @@ -35,37 +36,37 @@ def run():
print(env.get_template('header.html').render(full_header=True, header_page=True, config=config))
return

_run = form.getfirst('run', '')
_run = html.escape(form.getfirst('run', ''))

if _run.lower() == 'all':
page = _convert_to_integer(form.getfirst('page'), 1)
months = _convert_to_integer(form.getfirst('months'), config.months_to_search)
search = {item: form.getfirst(item) for item in ('users', 'tests', 'catalogs') if form.getfirst(item)}
search = {item: html.escape(form.getfirst(item)) for item in ('users', 'tests', 'catalogs') if form.getfirst(item)}
print(env.get_template('header.html').render(full_header=True, please_wait=True, config=config))
sys.stdout.flush()
print(env.get_template('bigtable.html').render(**prepare_bigtable(page, months, search)))
return

elif _run:
catalog = form.getfirst('catalog')
test = form.getfirst('test')
catalog = html.escape(form.getfirst('catalog'))
test = html.escape(form.getfirst('test'))

if catalog or test:
if form.getfirst('left'):
print(env.get_template('header.html').render(please_wait=True, config=config))
sys.stdout.flush()
print(env.get_template('leftpanel.html').render(**prepare_leftpanel(_run, test, catalog)))
else:
print(env.get_template('twopanels.html').render(run=_run, catalog=catalog, test=test, right=form.getfirst('right')))
print(env.get_template('twopanels.html').render(run=_run, catalog=catalog, test=test, right=html.escape(form.getfirst('right'))))
return

print(env.get_template('header.html').render(full_header=True, please_wait=True, config=config))
sys.stdout.flush()
if _run or getattr(config, 'use_latest_run_as_home', True):
print(env.get_template('matrix.html').render(**prepare_matrix(
run=_run,
catalog_prefix=form.getfirst('catalog_prefix'),
test_prefix=form.getfirst('test_prefix'),
catalog_prefix=html.escape(form.getfirst('catalog_prefix')),
test_prefix=html.escape(form.getfirst('test_prefix')),
)))
else:
print(env.get_template('home.html').render(general_info=config.general_info))