Skip to content

Factory for (SourceGalaxy)SelectField#532

Draft
tilmantroester wants to merge 4 commits into
masterfrom
selectfieldfactory
Draft

Factory for (SourceGalaxy)SelectField#532
tilmantroester wants to merge 4 commits into
masterfrom
selectfieldfactory

Conversation

@tilmantroester

Copy link
Copy Markdown
Member

This adds a factory for SourceGalaxySelectField. It works but I wonder if there needs to be some specialisation for the weak_lensing.SelectField and number_counts.SelectField cases.

No tests yet.

@codecov

codecov Bot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.9%. Comparing base (0216ee3) to head (58e2a09).
⚠️ Report is 209 commits behind head on master.

Files with missing lines Patch % Lines
firecrown/likelihood/source.py 75.0% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.0%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #532     +/-   ##
========================================
- Coverage   100.0%   99.9%   -0.1%     
========================================
  Files          50      50             
  Lines        5069    5077      +8     
  Branches      578     578             
========================================
+ Hits         5069    5075      +6     
- Misses          0       2      +2     
Files with missing lines Coverage Δ
firecrown/likelihood/number_counts.py 100.0% <ø> (ø)
firecrown/likelihood/weak_lensing.py 100.0% <ø> (ø)
firecrown/likelihood/source.py 98.8% <75.0%> (-1.2%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants